Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation #5741

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

PlayAnyData
Copy link
Contributor

@PlayAnyData PlayAnyData commented Oct 23, 2024

Updates README for fetch

All your links in this readme seem to be broken, so I included a link to main. I hope, this is fine. If I should do it for the others as well, I can do that.

Background

Struggled with this command.

Description

Markdown updates

Checklist

N/A

@@ -101,7 +101,7 @@ _See code:

## `hive artifact:fetch`

fetch artifacts from the CDN
fetch artifacts from the CDN. Note that the path shown in UI already contains `artifact`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -111,16 +111,16 @@ USAGE
FLAGS
--artifact=<option> (required) artifact to fetch (Note: supergraph is only available for federation projects)
<options: sdl|supergraph|metadata|services|sdl.graphql|sdl.graphqls>
--cdn.accessToken=<value> CDN access token
--cdn.endpoint=<value> CDN endpoint
--cdn.accessToken=<value> CDN access token (alternatively set via env var `HIVE_CDN_ENDPOINT`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link
Member

@dotansimha dotansimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comments :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants